Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rare cases, Aragorn predicts RNA genes with negative coordinates.
For example, in contig
NZ_CSQN01000072
, it predicts the following tRNA:Previously, start and stop positions were not validated, allowing such erroneous coordinates to persist. When written to the pangenome file, which stores coordinates as positive integers, the
-3
was converted to4294967293
.Now, with the updates made in the development branch (particularly in PR #206, which includes management of joined coordinates), extensive checks are performed on coordinates.
It has been decided that PPanGGOLiN should ignore genes predicted by Aragorn with invalid coordinates. tRNAs are only predicted to remove any CDS that would overlap them and have no other use in the PPanGGOLiN.
This PR addresses the issue in two scenarios: